Skip to content

chore: fix JavaScript lint errors (issue #12359)#12849

Open
titanniya542-spec wants to merge 2 commits into
stdlib-js:developfrom
titanniya542-spec:chore/fix-js-lint-12359
Open

chore: fix JavaScript lint errors (issue #12359)#12849
titanniya542-spec wants to merge 2 commits into
stdlib-js:developfrom
titanniya542-spec:chore/fix-js-lint-12359

Conversation

@titanniya542-spec

Copy link
Copy Markdown
Contributor

Description

This pull request fixes a JavaScript lint error in the evalpoly-compile example by making the final require statement a relative path.

Related Issues

Resolves #12359

Checklist

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored with assistance from AI.

Validation

  • node --check lib/node_modules/@stdlib/math/base/tools/evalpoly-compile/examples/index.js
  • git diff --check

Note: make lint-javascript-files FILES="lib/node_modules/@stdlib/math/base/tools/evalpoly-compile/examples/index.js" could not be run locally because make is not installed in this Windows environment.

@titanniya542-spec titanniya542-spec requested a review from a team June 13, 2026 07:35
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jun 13, 2026
@stdlib-bot

stdlib-bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/tools/evalpoly-compile $\\color{green}210/210$
$\\color{green}+0.00\\%$
$\\color{red}41/42$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}210/210$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Jul 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the desired change. Instead, you should restore the original example and simply disable the lint rule above the 'use strict' directive.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 6, 2026
@stdlib-bot stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants